Integrate miq-unicode.rb into smartstate

[djberg96]

This moves the methods from miq-unicode.rb from gems-pending into the smartstate repo directly. Since we're reopening a base class (String), I thought this would be a good opportunity to use Ruby's refinements. This ensures that we don't cause any entanglements with any other libraries, now or in the future.

Part of the gems-pending effort: ManageIQ/manageiq-gems-pending#231

Note that one other repo (virtfs-ntfs) uses a few of these methods so that will have to be addressed before we can remove miq-unicode.rb from gems-pending. Nevermind, that repo was archived.

The virt_disk repo uses identical methods but defines them locally.

[Fryguy]

Note that a lot of this code does not have automated tests. Can you verify at least one of these calls is being executed through automated tests so we can know that everything works properly?

[Fryguy]

cc @agrare

[djberg96]

Note that a lot of this code does not have automated tests.

Like, none of it as far as I can tell. Oof.

Can you verify at least one of these calls is being executed through automated tests so we can know that everything works properly?

I'll try to whip some specs for one of the files at least.

Update: ok, I found one test so far that calls it internally and it still works:

https://github.com/ManageIQ/manageiq-smartstate/blob/master/spec/metadata/VmConfig/VmConfig_spec.rb

[djberg96]

I copied over the specs from gems-pending as well (and updated them slightly). They pass.

[miq-bot]

Checked commits https://github.com/djberg96/manageiq-smartstate/compare/f9387b774fb3d42af016249e3629ea8553af0ca6~...f15a52df282def86f9e72918b5f5d2116c40904e with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
18 files checked, 12 offenses detected

lib/fs/fat32/directory_entry.rb

• ❗ - Line 52, Col 1 - Layout/EmptyLinesAroundClassBody - Extra empty line detected at class body beginning.
• ❗ - Line 538, Col 1 - Layout/EmptyLinesAroundClassBody - Extra empty line detected at class body end.

lib/miq_unicode.rb

• ❗ - Line 12, Col 11 - Naming/MethodName - Use snake_case for method names.
• ❗ - Line 16, Col 11 - Naming/MethodName - Use snake_case for method names.
• ❗ - Line 20, Col 11 - Naming/MethodName - Use snake_case for method names.
• ❗ - Line 24, Col 11 - Naming/MethodName - Use snake_case for method names.
• ❗ - Line 28, Col 11 - Naming/MethodName - Use snake_case for method names.
• ❗ - Line 32, Col 11 - Naming/MethodName - Use snake_case for method names.
• ❗ - Line 36, Col 11 - Naming/MethodName - Use snake_case for method names.
• ❗ - Line 40, Col 11 - Naming/MethodName - Use snake_case for method names.
• ❗ - Line 4, Col 11 - Naming/MethodName - Use snake_case for method names.
• ❗ - Line 8, Col 11 - Naming/MethodName - Use snake_case for method names.

[Fryguy]

LGTM. Will leave it to @chessbyte or @agrare