Remove the Hardware#m_bios method

[djberg96]

This is part of the ManageIQ/manageiq-gems-pending#231 effort to remove miq-uuid as a dependency anywhere except vmware.

Since this method doesn't appear to be used, let's remove it.

Cross repo tests: ManageIQ/manageiq-cross_repo-tests#140

[miq-bot]

Checked commit https://github.com/djberg96/manageiq/commit/81b291da0c846f9c1b299fc08408af052f08833d with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. ⭐

[agrare]

@roliveri @jerryk55 I assume this was used for smartstate scans, does this look familiar to you? Was it previously used but not anymore?

[jerryk55]

@agrare if it was it was from before my time. I don't ever remember seeing it used.

[roliveri]

I don't recall. Are the similar routines (like m_vm) currently used by SSA?

[agrare]

So I think the answer to "is this used anymore" is a definite yes. There are a number of m_ methods that appear to be called by smartstate (#20258 (comment))

[Fryguy]

manageiq/app/models/hardware.rb

Line 91 in 37f1c09

parent.hardware.send("m_#{e.name}", parent, e, deletes) if parent.hardware.respond_to?("m_#{e.name}")

Found via ag "\bm_#", but also can be found with org:ManageIQ m_#

[djberg96]

@Fryguy well what would you like me to do then?

[Fryguy]

Considering the method is used, I think you have to keep it. Unless you can show that the results from a smart state scan won't have the bios value anymore

[agrare]

@djberg96 Since you're trying to get rid of MiqUUID.clean_guid, and that is vmware specific, I think we should just drop the MiqUUID.clean_guid from core Hardware and clean the guid in vmware specific smartstate code that pulls the value

[chessbyte]

Closing because we cannot remove the m_bios method