Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited Documentation for Rate functions in Custom Animations: #4173

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sripathimanikanta
Copy link

@sripathimanikanta sripathimanikanta commented Feb 20, 2025

  • It was little misleading
  • Added a brief note to explain how to fix it
  • Added explicit code as comments in the example code

This is my first PR!!! Open for your suggestion and Advice....

Overview: What does this pull request change?

This change helps to fix this issue #4031...

Motivation and Explanation: Why and how do your changes improve the library?

This change helps in fixing documentation in Manim Building Block Page in Custom Animation Section
Where the code breaks when rate functions are used inside the played function as explained in the following example

Links to added or changed documentation pages

This is the section - https://docs.manim.community/en/stable/tutorials/building_blocks.html#creating-a-custom-animation
https://manimce--4173.org.readthedocs.build/en/4173/

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

sripathimanikanta and others added 2 commits February 20, 2025 16:22
- It was little misleading
- Added a brief note to explain how to fix it
- Added explicit code as comments in the example code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant