-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panic if TERM environment variable is "dumb" #219
Comments
Hi @jimblandy, thank you for reporting this issue. I'm having trouble recreating it on my local machine. Running Furthermore, if the panicking line is in the tester crate, I think it would be best to report the error there? |
Here's a test case: https://github.com/jimblandy/compiletest-issue-219 |
This is on Fedora. |
Okay, I filed an issue against the tester crate: messense/rustc-test#6 |
Thank you @jimblandy, that reproduces the issue for me here. I don't have time to look at the issue at the moment, unfortunately, let's hope someone else does. |
If I do a compiletest test run under Emacs, Emacs sets the
TERM
environment variable to"dumb"
, and then the test run panics:If I change the test command to
TERM=ansi cargo test
, then all is well.This is the panicking line, in the
tester
crate'srun_test_in_process
function:where
monitor_ch
is aSender<CompletedTest>
.The only thing I can imagine compiletest uses
TERM
for is the color in the output. So I'd guess that whoever is supposed to be receiving on this channel exited early for some color-related reason. Ideally, if color is not available, one should simply not emit the color escape codes.The text was updated successfully, but these errors were encountered: