From 996e05b0791d84e9ff27788a50b0dd5cb733c9d9 Mon Sep 17 00:00:00 2001 From: DanShatford <143026563+DanShatford@users.noreply.github.com> Date: Sun, 10 Sep 2023 11:49:46 +0100 Subject: [PATCH 1/2] docs: fix typo "spurius" > "spurious" --- README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 4e81deb..aa8af62 100644 --- a/README.md +++ b/README.md @@ -118,7 +118,7 @@ We can use the following five metrics to consider difference categories of error |Incorrect (INC)|the output of a system and the golden annotation don’t match| |Partial (PAR)|system and the golden annotation are somewhat “similar” but not the same| |Missing (MIS)|a golden annotation is not captured by a system| -|Spurius (SPU)|system produces a response which doesn’t exit in the golden annotation| +|Spurious (SPU)|system produces a response which doesn’t exit in the golden annotation| These five metrics can be measured in four different ways: @@ -172,7 +172,7 @@ __Putting all together:__ |Incorrect|2|0|2|3| |Partial|0|2|0|0| |Missed|1|1|1|1| -|Spurius|1|1|1|1| +|Spurious|1|1|1|1| |Precision|0.5|0.66|0.5|0.33| |Recall|0.5|0.66|0.5|0.33| |F1|0.5|0.66|0.5|0.33| @@ -182,9 +182,9 @@ __Putting all together:__ In scenarios IV and VI the entity type of the `true` and `pred` does not match, in both cases we only scored against the true entity, not the predicted one. You can argue that the predicted entity could also be scored as spurious, -but according to the definition of `spurius`: +but according to the definition of `spurious`: -* Spurius (SPU) : system produces a response which does not exist in the golden annotation; +* Spurious (SPU) : system produces a response which does not exist in the golden annotation; In this case there exists an annotation, but with a different entity type, so we assume it's only incorrect. From 3caba0b1c5d54bf4d79a46855bf4759b303c1393 Mon Sep 17 00:00:00 2001 From: Matthew Upson Date: Thu, 28 Sep 2023 12:41:48 +0200 Subject: [PATCH 2/2] fix: Grant write permission to CICD workflow --- .github/workflows/checks.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/checks.yaml b/.github/workflows/checks.yaml index 305b675..4db7836 100644 --- a/.github/workflows/checks.yaml +++ b/.github/workflows/checks.yaml @@ -1,5 +1,7 @@ name: CI Code Checks on: [pull_request] +permissions: + contents: write jobs: build: name: code checks @@ -41,4 +43,4 @@ jobs: folder: coverage - name: Type checking with mypy - run: mypy --config setup.cfg src \ No newline at end of file + run: mypy --config setup.cfg src