Relax Csla0011 for Commands

[ajj7060]

I see this was discussed here: MarimerLLC/cslaforum#817

I like the idea of this analyzer generally, and I know we can fix it by changing the ctor to a standard method and adding attributes, but we have hundreds of command objects and we have enough warnings to deal with, so to update from 4 to 5 I ended up just turning it off completely.

All of our command usages follow this:

public static MyCommand DoIt(string whatever) => DataPortal.Execute(new MyCommand(whatever));

public MyCommand() { }
private MyCommand(string whatever) => Whatever = whatever;

Its not clear to me what the benefits of changing the ctor to a method and using DataPortal to create the command instance are, and it adds an opportunity to do the wrong thing if the [RunLocal] gets forgotten. I don't think we've ever encountered a need to actually hit the server to initialize a command just before we go to execute it.

If the command doesn't require any parameters to execute, you're then forced to create an empty create method as well, again with a chance to forget [RunLocal]

CriteriaBase already seems exempt and it has managed properties as well, so it doesn't seem like allowing ctors for commands should be any kind of technical issue.

Thoughts?

[rockfordlhotka]

When @JasonBock wrote the analyzer we discussed whether it should apply to all the base types that support stereotypes, and I thought it should.

I know what you are talking about @ajj7060, as there is certainly work associated with adding dummy Create methods for each command type, and that's not productive.

Certainly one answer would be to relax the analyzer. Another would be for the data portal (at least with a command type) to not require an explicit RunLocal Create operation to be declared. Maybe that should be the behavior for all types?

[ajj7060]

Well I wasn't trying to say that criteriabase does it so command should to; its more the work it would require to satisfy this anaylzer, which for now has forced me to shut it off.

The comment about the criteriabase being obsolete b/c the dataportal can take multiple arguments is interesting though; there's only DataPortal.Execute<T>(T obj) still.

Now if you could do:
DataPortal.Execute<T>(param1, param2)

and have it end up in
[Execute] private void Execute(string param1, int param2)

That would eliminate the need for a ctor or a [Create] method. Then the only properties on the command, if any, would be outputs of the command.

[rockfordlhotka]

Oh, I like the idea of passing parameters to the command like that - interesting idea!

[rockfordlhotka]

@ajj7060 would you please add that as a feature suggestion in the Issues tab?

[rockfordlhotka]

If @JasonBock figured out how to serialize a tuple (I think you were playing with that at one point?) we could have a new "command base" that accepts parameters and returns a tuple as a result. That might be pretty cool!

var resultAsTuple = DataPortal.Execute<T>(param1, param2);

[ajj7060]

@ajj7060 would you please add that as a feature suggestion in the Issues tab?

Done. You can find it here: #1775

Let me know if it captures the idea or if there's anything to tweak.