Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI timing issues when the window is unfocused #3

Open
MarkMendell opened this issue Aug 5, 2016 · 0 comments
Open

MIDI timing issues when the window is unfocused #3

MarkMendell opened this issue Aug 5, 2016 · 0 comments
Labels

Comments

@MarkMendell
Copy link
Owner

Video (1.7MB)
(Chrome, 10.10.5 OSX)

Required reading

^^^ We do the two clock method for scheduling so that playback can stop. When unfocused, the setInterval loop gets called in a larger interval than its lookahead is. Easy fix would be to increase the lookahead amount (I changed PLAYBACK_LOOKAHEAD in js/playback.js to 1000 and there were no more timing issues) but that then makes pausing/stopping less responsive.

Maybe there's a way to detect if the window is unfocused, then increase the delay only then? As long as it doesn't add too much complexity, I think this would be the best option. Another option is to let the users set their own lookahead, but then that adds complexity to the UI.

@MarkMendell MarkMendell added the bug label Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant