-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update settings.cpp
+ fix some things as proper nouns
#27422
Open
classicrocker883
wants to merge
16
commits into
MarlinFirmware:bugfix-2.1.x
Choose a base branch
from
classicrocker883:bugfix-2.1.x-September2
base: bugfix-2.1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update settings.cpp
+ fix some things as proper nouns
#27422
classicrocker883
wants to merge
16
commits into
MarlinFirmware:bugfix-2.1.x
from
classicrocker883:bugfix-2.1.x-September2
+953
−893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classicrocker883
changed the title
Update
Update Sep 17, 2024
settings.cpp
+ fix Power-Loss Recovery / I2C as proper nounssettings.cpp
+ fix Power-Loss Recovery / I2C / Z-Probe|Offset as proper nouns
classicrocker883
changed the title
Update
Update Sep 21, 2024
settings.cpp
+ fix Power-Loss Recovery / I2C / Z-Probe|Offset as proper nounssettings.cpp
+ fix some things as proper nouns
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
3 times, most recently
from
September 28, 2024 01:10
37d77d6
to
aa44542
Compare
… into bugfix-2.1.x-September2
… into bugfix-2.1.x-September2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most of the file changes basically use the correct capitalization for Power-Loss Recovery and I2C and Z-Probe/Z-Probe Offset/Z-Offset and *-Axis (ex: X-Axis, Z-Axis)
Before:
...ect
After:
Other changes:
Better understaning/readability in settings.cpp
FIELD_TEST()
above and prior to code as to utilizeSettingsDataStruct
variable declarations (as it is with the remaining code structure)Added/updated language.h strings to correct/proper capitalization and such.
Requirements
Benefits
Better understand of code with updated comments using correct descriptions.
Added what was missing, and easier arrangement.
Configurations
Related Issues