-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Mellow/Fly RRF E3 V1.0 (STM32F407VG) #27466
base: bugfix-2.1.x
Are you sure you want to change the base?
Conversation
Added FLY_RRF_E3_V1
added FLY_RRF_E3_V1
Added Fly RRF E3 V1.0
you have board_build.variant = MARLIN_FLY_RRF_E3_V1 So there should be a folder buildroot/share/PlatformIO/variants/MARLIN_FLY_RRF_E3_V1 to define the new variant |
it uses marlin_STM32F407VGT6_CCM like BigTreeTech E3 RRF (which uses the same CPU/MCU) uses and doesn't have a separate definition either the only difference between this and the BigTreeTech board is that it has an entirely different pinout and less ports (BTT has more optional ones) |
Flash-based emulation is preferred since it doesn’t require an SD card to be present. |
#error "SD CUSTOM_CABLE is not compatible with Fly RRF E3 V1." | ||
#endif | ||
|
||
// TODO ? board has inbuilt WiFi (ESP8266) but probably already runs a version of DuetWebServer if you've ever used it on RRF before and i have no idea what you'd need to flash it with to get it to work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review how this is done on other boards like the BTT E3 RRF:
Marlin/Marlin/src/pins/stm32f4/pins_BTT_E3_RRF.h
Lines 397 to 406 in f0b115a
#if ENABLED(WIFISUPPORT) | |
// | |
// WIFI | |
// | |
#define ESP_WIFI_MODULE_COM 3 // Must also set either SERIAL_PORT or SERIAL_PORT_2 to this | |
#define ESP_WIFI_MODULE_BAUDRATE BAUDRATE // Must use same BAUDRATE as SERIAL_PORT & SERIAL_PORT_2 | |
#define ESP_WIFI_MODULE_RESET_PIN PA4 | |
#define ESP_WIFI_MODULE_ENABLE_PIN PA5 | |
#define ESP_WIFI_MODULE_GPIO0_PIN PA6 | |
#endif |
look at other examples
Yours
But you have not provided this variants directory so this line is invalid. |
the CI error is due to the tight formatting constraints on board pins files. |
We also need this PR merged since it’s used for one of the tests: |
added WiFi pinout (but EN is pulled up constantly) according to the schematic
now will pass Marlin CI pin formatting
aec9ce8
to
d45baa3
Compare
[env:FLY_RRF_E3_V1] | ||
extends = stm32_variant | ||
board = marlin_STM32F407VGT6_CCM | ||
board_build.variant = MARLIN_FLY_RRF_E3_V1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A custom variant is specified, but there's no MARLIN_FLY_RRF_E3_V1
folder included. Do you have the variant files or know where to get them?
This is about ready to merge, but we need to resolve the issue with the missing custom variant. If the |
Co-authored-by: Scott Lahteine <[email protected]>
5a6476e
to
c2d0008
Compare
This is still missing some pieces. Where is the best place to acquire them? |
Description
Since the Mellow/Fly RRF E3 V1.0 still wasn't supported i decided to add it myself, i thought, if i do add support i may aswell publish it for other people to have aswell (still had one of those boards around and didn't want to use RRF)
Requirements
Mellow/Fly RRF E3 V1.0 (should work directly with a standard Ender 3 config for another E3* motherboard)
Benefits
Added previously unsupported motherboard (incompatible pinout etc)
Potential issues
This motherboard doesn't seem to have an EEPROM chip so it NEEDS an SD card for EEPROM emulation