Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the codebase into "core" and "defaults" #23

Open
marc-thieme opened this issue Feb 27, 2024 · 2 comments
Open

Split the codebase into "core" and "defaults" #23

marc-thieme opened this issue Feb 27, 2024 · 2 comments

Comments

@marc-thieme
Copy link

When I diving into the codebase, I feel like I had a hard time distinguishing between code which belonged to "lemmify-core" and code which was already given sane defaults.

In this package, I would put the translations.typ, default-theorems in lib.typ, all of the styles.typ.

The reason I think this would have helped me is because I could basically skip all the aforementioned stuff when it comes to understanding the code. Or at least, I could search for it decidedly when I was looking for examples of how to define a style or theorem-kind.

@Marmare314
Copy link
Owner

As you have mentioned, there really are two features of this package. One is adding more numbering features to typst (ie numbering depending on headings, other theorems, ...) and the other is providing default styles, numbering patterns etc for theorems. Right now lemmify is really not great at either and they are quite entangled (even in the refactor). I would love to separate them, but I'm not quite sure how to do that yet.
There is already a package concerning the numbering i-figured, and there has been discussions on integrating that into typst natively. Unfortunately it looks like the native support might still take some time. I'm not sure if it would be possible to depend on i-figured for numberings.

@marc-thieme
Copy link
Author

Especially with regards to the numbering, I agree that proper handling of this is very convoluted. Over the past year, I grew my own implementation of the lemmify approach and I just completely skipped dealing with the numbering. I'm curious about other people, for me personall, it was never important for me.
Feel free to close the issue, thank you so much for the response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants