Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add teleport arg support to all points #77

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alan67160
Copy link
Contributor

moved teleport arg support from ClickBlockPoint.java to parent class ServerTutorialPoint.java, so teleport will now be available on every type of point

@MartenM
Copy link
Owner

MartenM commented Sep 30, 2023

So for the first time in ages, I actually loaded up the plugin.
What you want to achieve with this (if I read the previous issue correctly) is a path of checkpoints.

This is already possible:

javaw_6GnOvqMxI3.mp4

@alan67160
Copy link
Contributor Author

you are correct, but may I know how you disable the teleport at the checkpoint?

@MartenM
Copy link
Owner

MartenM commented Sep 30, 2023

you are correct, but may I know how you disable the teleport at the checkpoint?

Checkpoints don't teleport by default as far as I know. Only timed points do.

@alan67160
Copy link
Contributor Author

oh, I see
well, it was my partner added a timedpoint after the checkpoint

@alan67160
Copy link
Contributor Author

however, what is your opinion about moving the teleport argument to be globally available at all points?

@MartenM
Copy link
Owner

MartenM commented Sep 30, 2023

however, what is your opinion about moving the teleport argument to be globally available at all points?

I just quicky tried the plugin. I think it makes more sense to just not have it on some points at all, like the checkpoint.
So in that case, globally adding it might just add more confusion. Maybe as a default 'false' for some points it could work though?

@alan67160
Copy link
Contributor Author

OK, now every type of point has its own default tp value now
but, as it has multiple default values, the teleport config will now be always saving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants