Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System font size #7

Closed
UlanNurmatov opened this issue May 9, 2023 · 4 comments · Fixed by #8
Closed

System font size #7

UlanNurmatov opened this issue May 9, 2023 · 4 comments · Fixed by #8
Assignees
Labels
enhancement New feature or request

Comments

@UlanNurmatov
Copy link

UlanNurmatov commented May 9, 2023

The BBCodeText always remains the same size regardless of the system font size. For example it doesn't get bigger when font size is set to big.
Is it how it should be?

@MartenM MartenM self-assigned this May 9, 2023
@MartenM MartenM added the enhancement New feature or request label May 9, 2023
@MartenM
Copy link
Owner

MartenM commented May 9, 2023

The default font size is set in the stylesheet here.

This is intentional, but I agree it should follow the system font size. I will check if this is possible to improve accessibility.

@MartenM MartenM changed the title System font size [Feature] System font size as default May 9, 2023
@MartenM MartenM changed the title [Feature] System font size as default System font size May 9, 2023
@MartenM
Copy link
Owner

MartenM commented May 14, 2023

The project has been updated [1.4.1] to support different font sizes through the accessibility menu. This should hopefully resolve the issues you were having. If not feel free to re-open the issue.

Leaving stars on GitHub and likes on pub.dev is also highly appreciated :)

@UlanNurmatov
Copy link
Author

Thanks. It seems to resolve the issue.
One more question. When switching to dark mode, bbcode text remains dark. What should I add to ThemeData to make it white? This is my code:

darkTheme: ThemeData(
              appBarTheme: AppBarTheme(
                  color: mainColor,
                  foregroundColor: Colors.white,
                  iconTheme: IconThemeData(color: Colors.white)),
              colorScheme: ColorScheme.fromSwatch().copyWith(
                  primary: mainColor,
                  secondary: Colors.white,
                  brightness: Brightness.dark))

@MartenM
Copy link
Owner

MartenM commented May 24, 2023

Currently, the theme data is not being used by the BBCode widget.
I should probably look into that as well.

Edit: You can change the default style of the BBCode widget by passing in a style sheet. If you query your theme and supply it that it should also work properly I think. I opened a issue #9 for theme ThemeData though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants