Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to JSR.io #634

Draft
wants to merge 86 commits into
base: master
Choose a base branch
from
Draft

Migrate to JSR.io #634

wants to merge 86 commits into from

Conversation

MasterKale
Copy link
Owner

@MasterKale MasterKale commented Nov 5, 2024

A PR to track work required to support hosting the project on jsr.io.

Related to #571.

TODO

  • Figure out UMD hosting if everything was on JSR.io
    • Some combo of Deno + Rollup?
  • Figure out some kind of versioning script I can run to see what packages got updates between "now" and the latest version tag
    • This would be a hand-rolled, minimal replacement for lerna version
  • Figure out what deploying new releases would look like
    • Right now this would involve manually bumping versions in deno.jsonc files and then publishing
  • Decide if JSR hosting really can replace NPM and deno.land/x hosting, just replace deno.land/x, or maybe become a third option to maintain (😮‍💨)?

Updates

11/9: I've got v11 of everything hosted on JSR as "11.0.0-alpha2" releases while I'm still testing things out:

Screenshot 2024-11-08 at 10 50 16 PM

@MasterKale
Copy link
Owner Author

MasterKale commented Nov 5, 2024

Quick check-in, I managed to get @simplewebauthn/[email protected] published:

https://jsr.io/@simplewebauthn/[email protected]

This includes functional DOM types extraction just as I had before, except pulling from Deno's cache.

@MasterKale
Copy link
Owner Author

Checking in: all three packages have been been published to JSR as v11.0.0-alpha2 🎉

https://jsr.io/@simplewebauthn

Screenshot 2024-11-08 at 10 50 16 PM

All browser and server tests have been migrated to use Deno testing, and DNT has been removed from server.

Rollup is not being used right now to bundle browser. The UMD build is also not available with what's on JSR.io afaict. I still want to be able to offer it if I decide to migrate package hosting to JSR.io, though. I'm going to investigate this now that I feel reasonably certain that everything can exist as a Deno codebase.

@MasterKale
Copy link
Owner Author

I requested some assistance testing all this out over here:

#542 (comment)

@MasterKale
Copy link
Owner Author

Checkpoint: I've got @simplewebauthn/browser ready to publish to NPM, including with (a slightly larger) UMD bundle that still works as far back as IE10, to JSR, and to deno.land/x too because why not?

All three packages have had standardized test / build / publish scripts established. Tasks have been defined at the root deno.jsonc to enable running these from the project root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant