Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users are being unsilenced before their silence time end #418

Open
Phrosfire opened this issue Mar 6, 2025 · 1 comment
Open

Users are being unsilenced before their silence time end #418

Phrosfire opened this issue Mar 6, 2025 · 1 comment
Assignees

Comments

@Phrosfire
Copy link
Collaborator

Describe the bug

Some users who are silenced are having their silence ending early. From the code, I can see that the silence is setting banEnd, but it's still ending before that date is met.

To Reproduce
Steps to reproduce the behavior:

  1. Silence a user for several days
  2. User is unsilenced at daily reset

Expected behavior

User stays silenced until the endDate is met.

@nanubula
Copy link
Contributor

nanubula commented Mar 10, 2025

Are userReports ever cleaned up once the ban/silence ends? I could see if someone has multiple userReports and one silence has already ended, maybe that old report is unsilencing the user here.
If userReports aren't cleaned up to keep a history, maybe there should be another banState for reports that are no longer valid and can be ignored when checking expiredReports daily. I could be totally wrong on cause though, just my first thoughts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants