Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream on finish for putObject should pass back location, key, and bucket #67

Open
dmcmorris opened this issue Apr 13, 2020 · 0 comments
Open

Stream on finish for putObject should pass back location, key, and bucket #67

dmcmorris opened this issue Apr 13, 2020 · 0 comments

Comments

@dmcmorris
Copy link

dmcmorris commented Apr 13, 2020 •
edited
Loading

Currently when a readable stream passed into the Body finishes, the one call back with only a boolean is fired:

mock-aws-s3/lib/mock.js

Line 487 in 6b5aa02

done(null, true)

this should return the location, key and bucket just as the Buffer does:

done(null, { Location: dest, Key: search.Key, Bucket: search.Bucket })
@dmcmorris dmcmorris changed the title Stream on finish should pass back location, key, and bucket Stream on finish for putObject should pass back location, key, and bucket Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmcmorris