Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::optional for element value+value is set #282

Open
robUx4 opened this issue Mar 1, 2024 · 0 comments
Open

Use std::optional for element value+value is set #282

robUx4 opened this issue Mar 1, 2024 · 0 comments
Labels
abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) api-break breaks the API (e.g. programs using it will have to adjust their source code)

Comments

@robUx4
Copy link
Contributor

robUx4 commented Mar 1, 2024

As noted in #111 that could be a good candidate to use more standard types, now that we moved to C++17. It would also make it impossible to dissociate the value set from the value that is set or not.

However it may cause some code issues depending how people read/write the values. This is also trickier to EbmlBinary which doesn't hold a simple value or even EbmlMaster on which we don't really read/write values.

@robUx4 robUx4 added api-break breaks the API (e.g. programs using it will have to adjust their source code) abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) labels Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) api-break breaks the API (e.g. programs using it will have to adjust their source code)
Projects
None yet
Development

No branches or pull requests

1 participant