-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
always return true #32
Comments
/ping @olsgreen ;) |
@Grald Are you using the validator or trying to use it via DI or a facade? |
I'm seeing this, too, in Laravel. I've tried using it via DI and by plain instantiation (new EmailChecker). |
@josephsong Which version of Laravel are you using? |
Actually, Lumen v5.3.3. |
Well, it is funny. If I use yopmail.com as the domain for the test email, it does return false on the isValid call. But for any others I've tried from the list in this package, it still returns true. |
It seems that any of the domains in tests/EmailChecker/Tests/Adpater/BuiltInAdapterTest.php do come back as false. But any others in res/throwaway_domains.txt come back as true. I had just successfully implemented this package in WordPress, and all domains in the throwaway_domain.txt are marked as invalid. Seems to be something specific to Laravel/Lumen. |
i am using laravel 5.2 always return true even if wrong email address provided
The text was updated successfully, but these errors were encountered: