Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always return true #32

Open
Grald opened this issue Oct 5, 2016 · 7 comments
Open

always return true #32

Grald opened this issue Oct 5, 2016 · 7 comments

Comments

@Grald
Copy link

Grald commented Oct 5, 2016

i am using laravel 5.2 always return true even if wrong email address provided

@MattKetmo
Copy link
Owner

/ping @olsgreen ;)

@olsgreen
Copy link
Contributor

olsgreen commented Oct 6, 2016

@Grald Are you using the validator or trying to use it via DI or a facade?

@josephsong
Copy link

I'm seeing this, too, in Laravel. I've tried using it via DI and by plain instantiation (new EmailChecker).

@olsgreen
Copy link
Contributor

@josephsong Which version of Laravel are you using?

@josephsong
Copy link

Actually, Lumen v5.3.3.

@josephsong
Copy link

Well, it is funny. If I use yopmail.com as the domain for the test email, it does return false on the isValid call. But for any others I've tried from the list in this package, it still returns true.

@josephsong
Copy link

It seems that any of the domains in tests/EmailChecker/Tests/Adpater/BuiltInAdapterTest.php do come back as false. But any others in res/throwaway_domains.txt come back as true.

I had just successfully implemented this package in WordPress, and all domains in the throwaway_domain.txt are marked as invalid. Seems to be something specific to Laravel/Lumen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants