Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

FIX Update ghostAPI.ts to use environment URL instead of package URL when available #166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HenriquePi
Copy link

Fix setting of ghostURL to use user set URL instead of default

Currently script prioritizes CONF_URL which is a package default.

set CONTENT_API_URL to have priority to ensure user set URL has priority.

Fix setting of ghostURL to use user set URL instead of default

Currently script prioritizes CONF_URL which is a package default.

set CONTENT_API_URL to have priority to ensure user set URL has priority.
Copy link

changeset-bot bot commented Aug 12, 2024

⚠️ No Changeset found

Latest commit: 9755050

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Adammatthiesen
Copy link
Member

Adammatthiesen commented Aug 12, 2024

Hi, The recommended setup is to define the actual ghostURL within your astro.config.mjs instead of .env ( example ) as per our docs as well... since its not considered a protected key/secret by GhostCMS. Though from my own testing it should default to what ever option you have set without needing this change as i do not set a default ghostURL myself.

Side note... I will be rebuilding the Astro-GhostCMS integration system here soon as i have learned a ton from my developing StudioCMS

@Adammatthiesen Adammatthiesen added the question Further information is requested label Aug 16, 2024
@Adammatthiesen
Copy link
Member

Update: This project is now deprecated in favor of the astro-ghostcms-loader which is now compatible with astro v5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants