Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages from discord are echoed back #4

Open
NicholasFeldman opened this issue Apr 23, 2019 · 3 comments
Open

Messages from discord are echoed back #4

NicholasFeldman opened this issue Apr 23, 2019 · 3 comments

Comments

@NicholasFeldman
Copy link

NicholasFeldman commented Apr 23, 2019

In a channel with a default relay made:

image

I understand deleteMessages is a config setting, but how feasible would it be to not relay a message back to discord if it came from there originally, or matches the previous message?

@Maxopoly
Copy link
Owner

Maxopoly commented Apr 23, 2019

how feasible would it be to not relay a message back to discord if it came from there originally

Difficult. The messages from Kira are inserted into CivChat2 the same way a normal chat message would be. CivChat2 (and JukeAlert etc.) are not aware that Kira is a thing, the communication is facilitated entirely through the gateway plugin. To not bounce messages back, we'd have to change CivChat2 so it 'knows' about Kira, simple checks regarding content would not be sufficient as the same message could be sent from ingame simultaneously. I think it's better to not have Kira introduce another dependency trail into all the plugins, but instead be separate, have Kira depend on the plugins and use their API. So while I agree that it'd be nice to have an option to not bounce the same messages back, I think there is no reliable way to add it without having the down sides created outweigh the slight usability advantage.

@Maxopoly
Copy link
Owner

That being said I wouldn't be opposed to adding an option that does not send the ingame version of the message, if it matches the last message sent, as long as we add a bunch of warnings about it possibly swallowing duplicated messages etc.

@NicholasFeldman
Copy link
Author

I might have misworded it a bit, not displaying a message in discord if it's the same as the last one sent in discord is exactly what I'm suggesting. A simple check for content, username, & recent time should be enough to determine that it should be not displayed

Anything else, like a user sending the exact same message in game and in discord at the same time, is an edge case & a bit of a race condition which would either result in the message relayed to discord getting swallowed or it displayed twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants