Configuration error details

[asbjornu]

I've managed to commit a mergify.yml file that is seemingly invalid. Even though #69 is resolved, I'm not getting a lot of details on what the problem with my configuration file is:

Clicking the "View more details on Mergify" link just takes me back to the same URL. Hopefully you can let me know what the problem with the configuration file is, but I would also appreciate if the validation of the configuration file could be a bit more verbose in its output so I would be able to debug problems like these without any human assistance.

Here's my invalid config file:

pull_request_rules:
  - name: Automatically approve dependency updates
    conditions:
      - and:
          label=dependencies
      - or:
          author~=^dependabot(|-preview)\[bot\]$
          author~=^github-actions\[bot\]$
    actions:
      review:
        type: APPROVE

  - name: Automatic merge on approval
    conditions:
      - and:
          label=dependencies
      - or:
          author~=^dependabot(|-preview)\[bot\]$
          author~=^github-actions\[bot\]$
    actions:
      merge:
        method: merge
        strict: smart

  - name: Thank contributor
    conditions:
      - merged
      - -author~=^.*\[bot\]$
    actions:
      comment:
        message: "Thank you @{{author}} for your contribution!"

[sileht]

You missing the dash before each condition, eg:

pull_request_rules:
  - name: Automatically approve dependency updates
    conditions:
      - and:
          - label=dependencies
      - or:
          - author~=^dependabot(|-preview)\[bot\]$
          - author~=^github-actions\[bot\]$
    actions:
      review:
        type: APPROVE

  - name: Automatic merge on approval
    conditions:
      - and:
          - label=dependencies
      - or:
          - author~=^dependabot(|-preview)\[bot\]$
          - author~=^github-actions\[bot\]$
    actions:
      merge:
        method: merge
        strict: smart

  - name: Thank contributor
    conditions:
      - merged
      - -author~=^.*\[bot\]$
    actions:
      comment:
        message: "Thank you @{{author}} for your contribution!"

[asbjornu]

Thanks. But I have pretty much copy-pasted this from the documentation, which does not use dashes:

conditions:
  - or:
    - and:
        author=foo
        label=core
    - and:
        author=bar
        label=backend

[sileht]

Oh, the second example is wrong, I will fix it: #3047

[asbjornu]

Thanks. Now it complains that length of value must be at least 2 for dictionary value @ pull_request_rules → item 0 → conditions → item 0 → and. What I want is to express the following:

if (label == "dependencies" && (author == "dependabot[bot]" || author == "github-actions[bot]")) { … }

Is it possible to express this without duplicating the label condition?

[sileht]

Then just:

pull_request_rules:
  - name: Automatically approve dependency updates
    conditions:
      - label=dependencies
      - or:
          - author~=^dependabot(|-preview)\[bot\]$
          - author~=^github-actions\[bot\]$
    actions:
      review:
        type: APPROVE

conditions list already act as an and.

[asbjornu]

Yep, that worked. Thanks a bunch!

[sileht]

View more details on Mergify is a bit confusing, but the link is added by GitHub and we cannot remove it :(