-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mergify backport mangles backports by including unrelated changes #5132
Comments
Based on the undesired changes that mergify is including, it appears that mergify is including all changes from the |
We are facing a similar problem: Examples: |
Does anyone know if it's possible to force mergify to revert back to an earlier, non-bugged version? |
Only Mergify team can do that. |
Looks like its resolved now: frappe/frappe#28756 Edit: was just for that PR, broken for others. |
Still seem to be broken in Rook's repo :( |
👋 |
Hi! We released a fix for the backport action. You shouldn't reencounter the issue. |
Expected Behavior
Mergify backport cherry-picks only changes from the specific commit(s) being backported.
Actual Behavior
Mergify backport is adding more changes than just those from the commit being backported.
Please see these 3 backport PRs mergify created that are mangled in Rook's repo:
The first 2 are backports to different branches, from the same source PR which should update 8 files. The third is a different source PR, also updating 8 files.
The 3rd seems to be most interesting to me. It backports 2 commits. The last commit is the one that mergify is adding unexpected changes to. The first commit looks to be backported as intended.
Steps to Reproduce the Problem
Specifications
Pull Request URL: (see below)
Mergify Config URL: https://github.com/rook/rook/blob/4e727f302cadde7c8503ecc067899ee51e92413e/.mergify.yml
Revert "object: create cosi user for each object store" (backport #15035) rook/rook#15122
Revert "object: create cosi user for each object store" (backport #15035) rook/rook#15121
docs: update guides and examples for v1.16 release (backport #15105) rook/rook#15120
The text was updated successfully, but these errors were encountered: