Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mergify backport mangles backports by including unrelated changes #5132

Closed
BlaineEXE opened this issue Dec 9, 2024 · 8 comments
Closed

Mergify backport mangles backports by including unrelated changes #5132

BlaineEXE opened this issue Dec 9, 2024 · 8 comments
Assignees

Comments

@BlaineEXE
Copy link

Expected Behavior

Mergify backport cherry-picks only changes from the specific commit(s) being backported.

Actual Behavior

Mergify backport is adding more changes than just those from the commit being backported.

Please see these 3 backport PRs mergify created that are mangled in Rook's repo:

The first 2 are backports to different branches, from the same source PR which should update 8 files. The third is a different source PR, also updating 8 files.

The 3rd seems to be most interesting to me. It backports 2 commits. The last commit is the one that mergify is adding unexpected changes to. The first commit looks to be backported as intended.

Steps to Reproduce the Problem

  1. Mergify backport using GH action (config link below)
  2. Observe mangled backport (links above and below)

Specifications

@BlaineEXE
Copy link
Author

Based on the undesired changes that mergify is including, it appears that mergify is including all changes from the master branch in the backport instead of only the content of the commit(s) being backported.

@ankush
Copy link

ankush commented Dec 11, 2024

We are facing a similar problem:

Examples:

@BlaineEXE
Copy link
Author

Does anyone know if it's possible to force mergify to revert back to an earlier, non-bugged version?

@ankush
Copy link

ankush commented Dec 12, 2024

Only Mergify team can do that.

@akhilnarang
Copy link

akhilnarang commented Dec 12, 2024

Looks like its resolved now: frappe/frappe#28756

Edit: was just for that PR, broken for others.

@DouglasBlackwood DouglasBlackwood self-assigned this Dec 12, 2024
@BlaineEXE
Copy link
Author

Still seem to be broken in Rook's repo :(

@jd
Copy link
Member

jd commented Dec 13, 2024

👋
Thanks for reporting! We'll look into this ASAP.

@DouglasBlackwood
Copy link

Hi! We released a fix for the backport action. You shouldn't reencounter the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants