Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutocompleteManager + MessageKit #7

Open
mmuharem opened this issue Jul 6, 2018 · 7 comments
Open

AutocompleteManager + MessageKit #7

mmuharem opened this issue Jul 6, 2018 · 7 comments
Labels
question Further information is requested

Comments

@mmuharem
Copy link

mmuharem commented Jul 6, 2018

Hey Nathan,

I've been able to get the AttachmentManager plugin working on MessageKit 1.0 from MessageInputBar 0.2 using example code written in the InputAccessoryBar 2.1, however, I am unable to successfully get AutoCompleteManager working. The problem that I find is that when I enter in the prefix, @, the table appears but is blank.

screen shot 2018-07-06 at 12 50 29 am

I thought this was peculiar so I then started to print out the users that were being returned in the

'func autocompleteManager(_ manager: AutocompleteManager, autocompleteSourceFor prefix: String) -> [AutocompleteCompletion] ',

and it seems to be a loop that continues to run while the prefix exists (note the scroll indicator on the right. When I started to take the screenshot, it was in the middle of scroll bar). Note, I do not find this behavior in the InputAccessoryBar project. My guess is that this would explain why the table is not being updated as the values continue to be updated too quickly for the table to register. I thought this had to do with the asynccompletions, so I removed those but to no avail.

screen shot 2018-07-06 at 12 52 43 am

Any help in this matter would be appreciated!

@nathantannar4
Copy link
Member

Thanks, I introduced this bug when trying to fix another. I'll push a fix soon.

Sent with GitHawk

@nathantannar4
Copy link
Member

Thanks for your patience. Still haven't fully released this yet 🙂

Sent with GitHawk

nathantannar4 added a commit that referenced this issue Jul 6, 2018
@nathantannar4 nathantannar4 mentioned this issue Jul 6, 2018
@SD10
Copy link
Member

SD10 commented Jul 6, 2018

This weekend this should be usable from MessageKit/MessageKit branch development. It won't be on master until the official 2.0 release. Which is likely still a few weeks away. Fwiw, I'm using the MessageKit/MessageKit branch secret-branch for my work -- this change could be merged there as well

@mmuharem
Copy link
Author

mmuharem commented Jul 6, 2018

I appreciate the help Nathan and Steven, and the update of MessageInputBar 0.2.1!

I was able to use the development branch and the MessageInputBar 0.2.1 in order to get a fully working autocomplete and attachment manager built.

I did try with the secret-branch but there was a slight UI issue when you do an @ mention first and then try to add a picture second - it was not showing the tableview in the top stack view as there were layout constraints that broke. Just an FYI of my experience

Again, the help was very much appreciated! Keep up the great work!

@ghost
Copy link

ghost commented Sep 18, 2018

How did you make to import AutocompleteManager in a MessageKit project ?

When I import MessageInputBar and MessageKit, Xcode find 2 definition of multiples class because MessageKit use MessageInputBar

@nathantannar4
Copy link
Member

@benbenz you have to be using MessageKit 1.1 which is in pre release on the MessageKit development branch

Sent with GitHawk

@ghost
Copy link

ghost commented Sep 24, 2018

@nathantannar4 Thank you

@SD10 SD10 added the question Further information is requested label Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants