Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve recipe 17.5 by using tspop or link_ancestors #433

Open
bhaller opened this issue Mar 20, 2024 · 0 comments
Open

improve recipe 17.5 by using tspop or link_ancestors #433

bhaller opened this issue Mar 20, 2024 · 0 comments
Labels
enhancement long-term trees related to tree-seq, tskit, etc.

Comments

@bhaller
Copy link
Contributor

bhaller commented Mar 20, 2024

Recipe 17.5 (local ancestry using tree-seq) is outdated in its techniques. See:

https://groups.google.com/d/msgid/slim-discuss/f7a2c222-660f-4a73-a43b-e16b39abdc19n%40googlegroups.com

As @petrelharp says there, tspop or link_ancestors now provide better solutions.

Of course, the recipe is also demonstrating how to do stuff in Python yourself. So perhaps we should keep the existing code, and then say "but there's a better way to do this!" and show the modern solution to the problem as well?

@bhaller bhaller added enhancement trees related to tree-seq, tskit, etc. long-term labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement long-term trees related to tree-seq, tskit, etc.
Projects
None yet
Development

No branches or pull requests

1 participant