Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking "No" in "File has been modified externally" dialog, or failing to click soon enough, produces a relentless accumulation of more dialogs #476

Open
petrelharp opened this issue Oct 7, 2024 · 4 comments

Comments

@petrelharp
Copy link
Collaborator

To replicate:

  1. Open a file in SLiMgui.
  2. Open the same file in another editor, and make a change to it (and save the change).
  3. Go back to SLiMgui, and get the dialog:
File test2.slim has been modified externally (on disk); do you wish to reload it?

Desired behavior: clicking "No" makes the dialog go away.

Actual behavior: clicking "No" makes the dialog reappear. The only way to exit this that I can find is to kill SLiMgui.

Other odd things happen: for instance, if instead of clicking on the dialog, I just move the dialog window out of the way, then another one appears in it's place:
Screenshot from 2024-10-06 20-46-44

However, clicking "Yes" on the first dialog box works fine (but, not subsequent ones).

@petrelharp
Copy link
Collaborator Author

This one is also not blocking - however, I do risk losing changes I made in SLiMgui but forgot about, so it's somewhat more worrisome.

@bhaller
Copy link
Contributor

bhaller commented Oct 7, 2024

Hmm, not great. Funny, I tested it thoroughly when I implemented this feature a while back; I wonder what changed? Are you running with Qt5 or Qt6? (The About panel will tell you.) As for the risk of losing changes you forgot to save, note that SLiMgui does have an autosave feature, which you can turn on in the Preferences panel.

@petrelharp
Copy link
Collaborator Author

I'm using GUI version 5.3, Qt 5.15.13, Git-SHA-1 f872f3d. I could upgrade to Qt6 if you like?

@bhaller
Copy link
Contributor

bhaller commented Oct 7, 2024

I'm using GUI version 5.3, Qt 5.15.13, Git-SHA-1 f872f3d. I could upgrade to Qt6 if you like?

Well, I have no idea whether it would fix this issue or not, but if it's easy for you to do so, sure, why not? Let's obtain that data point. I think it's probably a good idea for everybody who isn't on an ancient platform to be on Qt6 now anyhow; there haven't been any reported problems with the switch, and it is likely to fix random little bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants