Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump package to v302.0.0 and remote-feature-flag-controller to 1.5.0 #5346

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

smilingkylan
Copy link
Contributor

Explanation

Bump remote-feature-flag-controller and core package

DDDDDanica
DDDDDanica previously approved these changes Feb 14, 2025
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we are introducing a new change to the src/ or tests/ directory of a package and releasing that package in the same PR. I realize we might be doing this to save time, but we don't typically do this as it makes things confusing when looking back at the history. We tend to keep any changes to release PRs just to satisfy the release itself. Can we cut a new release in a separate PR?

(Edit: Oh, I see we have #5341. Perhaps we should merge that first?)

@smilingkylan
Copy link
Contributor Author

smilingkylan commented Feb 14, 2025

#5341

Are you able to merge that PR? For whatever reason it doesn't seem like it will let me

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants