Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node.engines field in package.json #216

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Update node.engines field in package.json #216

merged 3 commits into from
Nov 15, 2023

Conversation

legobeat
Copy link
Contributor

This should more correctly reflect actual intended support in most cases:

  • Odd-numbered versions are effectively ephemeral and supporting anything but the most recent doesn't seem meaningful
  • Signaling recent minors for maintenance/LTS in means less overhead in supporting the older runtimes.

@legobeat legobeat marked this pull request as ready for review July 31, 2023 16:00
@legobeat legobeat requested a review from a team as a code owner July 31, 2023 16:00
mcmire
mcmire reviewed Jul 31, 2023
View reviewed changes
constraints.pro Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@legobeat legobeat requested a review from mcmire August 1, 2023 00:52
@legobeat legobeat requested a review from a team August 8, 2023 09:47
@legobeat legobeat requested a review from a team October 31, 2023 00:56
@mcmire mcmire mentioned this pull request Nov 1, 2023
Merged
mcmire
mcmire approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Let's do it!

Gudahtt
Gudahtt approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 085b701 into MetaMask:main Nov 15, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @mcmire @Gudahtt