Chunks #2
Open
Chunks #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use when pulling docker images, to fix bug where shiplift would error if multiple JSON values were returned in a single HTTP chunk
bossmc
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Add function for doing a stream POST and converting the HTTP chunks to JSON values.
HTTP chunks can contain one or more JSON values. This is currently handled in
Image::buildbut notImage::pull.When running with WSL2 and Docker Desktop, shiplift errors when pulling an image that already exists because Docker returns two JSON values in a single chunk.
How did you verify your change:
Ran the imagepull example with the same argument twice in succession.
What (if anything) would need to be called out in the CHANGELOG for the next release:
Nothing