Skip to content

Commit

Permalink
fixing scrolling issue mentioned in Issue apache#142
Browse files Browse the repository at this point in the history
  • Loading branch information
@Mghrabi
Mghrabi committed May 13, 2023
1 parent 194ff0e commit 850e275
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions frontend/src/components/frame/Frame.module.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@
.MetaChart {
@extend .Chart;
height: 517px;
border: 1px solid black;
}

.FlexContentWrapper {
Expand Down

1 comment on commit 850e275

@Mghrabi
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were many solutions I could think of, but I approached the safest solution that taking into consideration the future development of that feature, I simply drew a border line around that screen to make it obvious to users that it's a screen, not a normal white space. Solutions I thought of doing:

  1. I could have set the Height of the screen to be auto and that should have solved the problem FOR NOW as the feature isn't already in use (from my understanding)
  2. I could have made a simple code checking if the number of elements is 0, and if so it should remove that white space (screen) till the number of elements becomes at least 1, then shows the screen. But this solution will edit the code structure a bit and could be against the future plans as this screen functionality is still not 100% clear to me.

Please sign in to comment.