Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android form looks broken (iOS works) #52

Open
jd327 opened this issue Aug 19, 2016 · 9 comments
Open

Android form looks broken (iOS works) #52

jd327 opened this issue Aug 19, 2016 · 9 comments

Comments

@jd327
Copy link

jd327 commented Aug 19, 2016

iOS:

ios

Android:

android

RN 0.30.0 / react-native-form-generator@^0.9.6

The form is pretty much a few simple links:

<Form>
  <Separator ... />
  <LinkField .../>
</Form>

What am I missing?

@MichaelCereda
Copy link
Owner

Yes that's actually the theme for ios.. Can you post your code? Thanks

On Fri, Aug 19, 2016, 2:27 PM Ivan Akimov [email protected] wrote:

iOS:

[image: ios]
https://cloud.githubusercontent.com/assets/1404596/17820025/91a6e5a8-65ff-11e6-8461-279a443f9440.png

Android:

[image: android]
https://cloud.githubusercontent.com/assets/1404596/17820029/9587ed48-65ff-11e6-8f5b-256d4f77d4dd.png

RN 0.30.0 / react-native-form-generator@^0.9.6

The form is pretty much a few simple links:

What am I missing?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#52,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGjfmqm9DLilbkssPHriEDJjS7_HPHjks5qhfWsgaJpZM4Jouye
.

Michael Cereda
http://michaelcereda.com

@jd327
Copy link
Author

jd327 commented Aug 19, 2016

Thanks for the quick reply. Here's the edited version:

...
const styles = StyleSheet.create({
    form: {
        backgroundColor: '#faf9f7',
        flex: 1
    },
    container: {
        borderBottomColor: '#ddd'
    }
});
...
return (
    <View style={styles.form}>
        <Form>
            <Separator label="Support" containerStyle={styles.container} />
            <LinkField label="Send Feedback" onPress={...} containerStyle={styles.container} />
            <Separator label="Legal" containerStyle={styles.container} />
            <LinkField label="Terms of Service" onPress={...} containerStyle={styles.container} />
            <LinkField label="Privacy Policy" onPress={...} containerStyle={styles.container} />
        </Form>
    </View>
);
...

@MichaelCereda
Copy link
Owner

I'm going to run some tests later today.
Thank you

@ssomnoremac
Copy link

Yeah, I'm struggling with this library on Android. Could use more style options in the mean time. For example SwitchField labels are not centered as the first comment shows.

@MichaelCereda
Copy link
Owner

I'm about to release final fix on android.
I apologize for the delay but I have been very busy lately.

On Fri, Aug 26, 2016, 2:11 PM Cameron Moss [email protected] wrote:

Yeah, I'm struggling with this library on Android. Could use more style
options in the mean time. For example SwitchField labels are not centered
as the first comment shows.


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#52 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGjfkZh_zaN8oovA7phsdqtT1wCt-F_ks5qjyv3gaJpZM4Jouye
.

Michael Cereda
http://michaelcereda.com

@ssomnoremac
Copy link

great, yeah, I'm just noticing the props on Switch for styles. That should get me what I need.

@MichaelCereda
Copy link
Owner

Yes there are a lot of style props.. Check also the example.

On Fri, Aug 26, 2016, 3:01 PM Cameron Moss [email protected] wrote:

great, yeah, I'm just noticing the props on Switch for styles. That should
get me what I need.


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#52 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGjfoZ6bKvoEQ1pHVNNnHXRKXuzAU9zks5qjzf8gaJpZM4Jouye
.

Michael Cereda
http://michaelcereda.com

@jd327
Copy link
Author

jd327 commented Aug 31, 2016

@MichaelCereda any updates on this?

@MichaelCereda
Copy link
Owner

I'm working on it today.. I'll text here soon.

On Wed, Aug 31, 2016, 2:47 PM Ivan Akimov [email protected] wrote:

@MichaelCereda https://github.com/MichaelCereda any updates on this?


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#52 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGjfhkEsWdQOIyeml6Zex-NYrti4YkEks5qlcxNgaJpZM4Jouye
.

Michael Cereda
http://michaelcereda.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants