Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical text alignment seems off with React Native 0.33 #61

Open
jamieathans opened this issue Sep 11, 2016 · 3 comments
Open

Vertical text alignment seems off with React Native 0.33 #61

jamieathans opened this issue Sep 11, 2016 · 3 comments

Comments

@jamieathans
Copy link

simulator screen shot 11 sep 2016 9 29 34 am

It maybe related to Centre text in case where the distance between baselines is larger than the font size (68d483e) which seems to effect text lIne height.

@MichaelCereda
Copy link
Owner

I'm going to take a look. Apologies but I didn't have time to do a release
in the last weeks.
I'm releasing the new version with a lot of fixes and improvements.
Thank you

On Sat, Sep 10, 2016, 8:12 PM Jamie Athanassakis [email protected]
wrote:

[image: simulator screen shot 11 sep 2016 9 29 34 am]
https://cloud.githubusercontent.com/assets/16371427/18414333/d4d193cc-7802-11e6-9dfa-266272ebd5b4.png

It maybe related to Centre text in case where the distance between
baselines is larger than the font size (68d483e)
facebook/react-native@68d483e
which seems to effect text lIne height.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#61,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGjfhvXij_VPHGBBUblAx43acxkZvxtks5qo0d3gaJpZM4J53b4
.

Michael Cereda
http://michaelcereda.com

@jbrodriguez
Copy link
Contributor

jbrodriguez commented Sep 14, 2016

@jamieathans I solved it by passing alignItems: 'center' to containerStyles prop.

@msageryd
Copy link

I also saw this, but I have wrapped all the fields in my own wrapper so it's easy to handle this in one place instead of passing alignItems to every field. I can recommend wrapping the fields. This makes repetitive tasks as for example adding icons to fields, easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants