Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting in Vulkan any extension not perfect #291

Open
stefano2734 opened this issue Sep 6, 2023 · 6 comments
Open

Sorting in Vulkan any extension not perfect #291

stefano2734 opened this issue Sep 6, 2023 · 6 comments

Comments

@stefano2734
Copy link

stefano2734 commented Sep 6, 2023

Sorting in Vulkan any extension not perfect

Khronos first with khr ist ok.
EXT is here next.

But then there is some chaos.

sorting in OpenGL extensions is alphabetically.

@MightyCreak
Copy link
Owner

Can you give some examples?

From what I see it follows the order in features.txt

@stefano2734
Copy link
Author

stefano2734 commented Sep 9, 2023

in Extensions that are not part of any Vulkan Version.
An example:
VK_KHR_Map_Memory2 is last in table.

VK_Google is before VK_AMD

mostly VK_KHR are at the begin of the table.

so it is partly sorted, and features are added at the end without new sorting.

@MightyCreak
Copy link
Owner

Yes, it's kinda intentional actually.

As you can see here, the extensions aren't sorted in the original features.txt file and Mesamatrix simply follows the same order.

I could sort the extensions alphabetically, but I don't know how much this order is important in the original file...

@stefano2734
Copy link
Author

Khronos with KHR is first and EXT is second priority for the Mesa Guys in development.
And then alphabetical of the others in sorting is logic.
They will do little action and sort, if you give them a hint or issue.

@MightyCreak
Copy link
Owner

I'd rather the source being changed upstream instead of arbitrarily change the order in Mesamatrix. I'm not expert enough in 3d drivers programming to know which extensions should be higher up in the list, also, it could change without me knowing, and also it's no regular sorting (KHR, then EXT, then the rest).

I think it would be better to open an issue in mesa and ask the devs if they would be willing to re-order the extensions in features.txt (or if they have a preferred sorting order that they'd like to see in Mesamatrix)

@stefano2734
Copy link
Author

With Vulkan 1.4 some „sorting“ is done by transfer of some features to table 1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants