Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade our install of column-setter #181

Open
jonathanstegall opened this issue Feb 4, 2022 · 2 comments
Open

Upgrade our install of column-setter #181

jonathanstegall opened this issue Feb 4, 2022 · 2 comments

Comments

@jonathanstegall
Copy link
Member

Column Setter has released a version 2. I'd like to try upgrading.

@jonathanstegall
Copy link
Member Author

jonathanstegall commented Feb 4, 2022

Migration steps:

  1. copy in the new _column-setter.scss
  2. make sure we have all the correct variables from _column-settings.scss in our variables.scss
  3. run the automated sass-migrator division **/*.scss to migrate the math functions

at this point, running gulp styles results in a lot of max-width error messages that we need to figure out.

changing $max-width: null; to $max-width: 80em; in variables.scss stops all the errors, but it's possible/likely that it has significant CSS implications.

@jonathanstegall
Copy link
Member Author

Basically we need to run a diff on the current CSS and the CSS with the migrated Column Setter, but we need to do it on an expanded version of the CSS so we can see what individual CSS declarations might be different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant