Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High sample rate audio doesn't play (352.8kHz & 384kHz) #138

Open
Azazel55605 opened this issue Jan 7, 2025 · 1 comment
Open

High sample rate audio doesn't play (352.8kHz & 384kHz) #138

Azazel55605 opened this issue Jan 7, 2025 · 1 comment
Labels
Bug Issue was opened via the bug report template. wontfix This will not be worked on

Comments

@Azazel55605
Copy link

What device did this occur on?

Phone (2)

What version of Android is your device running?

15

App Version

v2.0.0-rc.3

Summary

The player will not play flac files with a sample rate of 384k and a bit depth of 24 bit.

This is not exclusive to this Version as the same issue is present in the regular Google Play release.

Files with a lower sample rate (128k) work without issue.

@Azazel55605 Azazel55605 added Bug Issue was opened via the bug report template. needs review Issue is ready to be reviewed by a maintainer. labels Jan 7, 2025
@cyanChill
Copy link
Member

cyanChill commented Jan 7, 2025

So I went to investigate this a bit (since all of my audio is 44.1kHz) using sample tracks from https://msbtechnology.com/support/bit-perfect-testing/, and found that what we have currently works fine until we hit the really high-end (352.8kHz & 384kHz).

Our app uses a package that handles the audio playback & media control notifications which uses ExoPlayer2, which according to this issue doesn't seem to be supported out of the box. Just for fun, I tried a fork of the package that utilizes the latest version (ExoPlayer3 via Media3) and encountered the same issue.

I think one potential solution is to downsample, but I don't have that much technical knowledge for ExoPlayer and general Android API to implement this, along with how the package we use is structured to handle audio playback (since we probably need to patch it).

  • I think how other apps like PowerAmp do this (according to this reddit post) is that they don't use Android's native APIs to accomplish this, but instead maybe use something like ffmpeg.

As it stands, it'll probably stay like this. If someone creates a PR that works, I'll happily merge it. I'll keep this issue open to let others be aware of the issue with really high sample rate audio.

@cyanChill cyanChill added Not Planned This isn't planned for or won't be implemented and removed needs review Issue is ready to be reviewed by a maintainer. Not Planned This isn't planned for or won't be implemented labels Jan 7, 2025
@cyanChill cyanChill changed the title Issue with high-res .falc files High sample rate audio doesn't play (352.8kHz & 384kHz) Jan 7, 2025
@cyanChill cyanChill added the wontfix This will not be worked on label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issue was opened via the bug report template. wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants