Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard visibility breaks with integration of local_auth #15

Closed
viktor-morin opened this issue May 9, 2020 · 7 comments
Closed

keyboard visibility breaks with integration of local_auth #15

viktor-morin opened this issue May 9, 2020 · 7 comments
Labels
bug Something isn't working

Comments

@viktor-morin
Copy link

See following issue, same issue using this package

adee42/flutter_keyboard_visibility#61

@MisterJimson MisterJimson added the bug Something isn't working label May 9, 2020
@MisterJimson
Copy link
Owner

Thanks for the report. I believe its a side effect of the way this plugin was originally coded.

I've just done the Flutter 1.12 Android plugin migration on the 3.0.0 branch. Would you be willing to see if that branch fixes your issue?

You should be able to depend on that branch by doing

flutter_keyboard_visibility:
    git:
      url: git://github.com/MisterJimson/flutter_keyboard_visibility.git
      ref: 3.0.0

@viktor-morin
Copy link
Author

I will check later this week and come back with the result, thanks!

@emersonsiega
Copy link

Thanks for the report. I believe its a side effect of the way this plugin was originally coded.

I've just done the Flutter 1.12 Android plugin migration on the 3.0.0 branch. Would you be willing to see if that branch fixes your issue?

You should be able to depend on that branch by doing

flutter_keyboard_visibility:
    git:
      url: git://github.com/MisterJimson/flutter_keyboard_visibility.git
      ref: 3.0.0

Tried using this version here, but the problem still happening.

@viktor-morin
Copy link
Author

Thanks for the report. I believe its a side effect of the way this plugin was originally coded.
I've just done the Flutter 1.12 Android plugin migration on the 3.0.0 branch. Would you be willing to see if that branch fixes your issue?
You should be able to depend on that branch by doing

flutter_keyboard_visibility:
    git:
      url: git://github.com/MisterJimson/flutter_keyboard_visibility.git
      ref: 3.0.0

Tried using this version here, but the problem still happening.

You where faster than me, thanks for testing.

@MisterJimson
Copy link
Owner

Hmm I will need to look deeper into this. Thanks for helping test.

@MisterJimson
Copy link
Owner

#19 was just fixed so I'm hoping this issue is related. I'll be testing 3.1.0 for this issue soon, but if someone else has a chance to test and report back here that would be fantastic.

@viktor-morin
Copy link
Author

#19 was just fixed so I'm hoping this issue is related. I'll be testing 3.1.0 for this issue soon, but if someone else has a chance to test and report back here that would be fantastic.

Using following code in MainActivity.kt

package com.example.validate_github

import androidx.annotation.NonNull;
import io.flutter.embedding.android.FlutterFragmentActivity
import io.flutter.embedding.engine.FlutterEngine
import io.flutter.plugins.GeneratedPluginRegistrant

class MainActivity: FlutterFragmentActivity() {
    override fun configureFlutterEngine(@NonNull flutterEngine: FlutterEngine) {
        GeneratedPluginRegistrant.registerWith(flutterEngine);
    }
}

Together with:

local_auth:
flutter_keyboard_visibility: ^3.1.0

Works!
1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants