-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MMG3D_Set_triangles switches the second and third vertices #265
Comments
There seems to be the same inconsistency in MMGS : mmg/src/mmgs/API_functions_s.c Line 541 in fe5ce20
|
Hi, Thank you for your contribution. Indeed, it doesn't make much sense to permute the triangles vertices but does it create an error in Mmg or is it an issue for you? I think that in any cases, when Mmg analyzes the surface mesh provided by the user, it tries to find a consistent orientation for connected pieces of surface and may change the orientation of your input triangles:
Thank you by advance for your feedback, |
So far I did not observe any error in Mmg due to triangle orientation. Nevertheless, I think there should be a consistent behavior between Currently, a round trip using |
Hi, I agree that a consistent behaviour would be preferable: I just wanted to be sure on the consequences of the vertices swaps. As it doesn't create errors, I prefer to integrate your improvement in the 'develop' branch that in the 'master' one (in which I try to only directly merge hot fixes): it will be integrated in the next release of Mmg. Best |
It is obvious when looking at the source code :
mmg/src/mmg3d/API_functions_3d.c
Line 943 in fe5ce20
However, MMG3D_Set_triangle (actually used in the examples) does not perform the switch.
The text was updated successfully, but these errors were encountered: