-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Michael/plugins #108
base: main
Are you sure you want to change the base?
Michael/plugins #108
Conversation
the idea looks good to me. what are some usecases for this? |
If you remember, we talked about this a few months ago. It's to enable the extension of the REPL functionality with 3rd third-party plugin. For example, a fuzzy search for files and tests, suspend mode, etc.. |
@MoLow wdyt? |
@mikicho lets add it! |
@MoLow how to we want to declare on the plugins? like jest with a config file? {
"watchPlugins": [
// default
"jest-watch-suspend",
// configure
[
"jest-watch-suspend", {
// override key press
"key": "s",
// override prompt
"prompt": "suspend watch mode",
// starts in suspend mode
"suspend-on-start": true
}
]
]
} |
maybe we can simplify it to just be a map of |
@MoLow, I'm OK with whatever you prefer, but I think we might want to add more configurations in the future and it will be a breaking change. |
My suggestion was that each plugin can define its own schema for configuration. why would it be a breaking change? |
Inspired by Jest watch plugins API: https://jestjs.io/docs/watch-plugins
@MoLow please let me know what you think
Also, should we be compatible (as much as possible) to Jest API for easy migration?