Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when converting pin to byte in custom devices #1923

Open
neilenns opened this issue Jan 16, 2025 · 0 comments · May be fixed by #1918
Open

Crash when converting pin to byte in custom devices #1923

neilenns opened this issue Jan 16, 2025 · 0 comments · May be fixed by #1918
Assignees
@neilenns
Labels
bug Something isn't working in a officially released version

Comments

@neilenns
Copy link
Contributor

Reported by a user in Discord

@elral and I have no idea why this is happening, and only happening on that one person's computer. Neither of us can reproduce it locally.

Image

The code should be doing TryParse instead of simply casting, and should have a try/catch.
@neilenns neilenns added the bug Something isn't working in a officially released version label Jan 16, 2025
@neilenns neilenns self-assigned this Jan 16, 2025
@neilenns neilenns linked a pull request Jan 16, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neilenns neilenns

Labels
bug Something isn't working in a officially released version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use TryParse when converting custom device pins neilenns/MobiFlight-Connector
1 participant
@neilenns