-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the www.youtube.com HTTP test to use m.youtube.com as the host #143
Comments
Fixed. |
Fixed as in you changed the scheduler to not send to www.youtube.com? That's not really fixed as youtube is not the only culprit and users can On Mon, Nov 26, 2012 at 6:00 AM, drchoffnes [email protected]:
|
Correct on the change. Agreed that mobiperf should handle other response codes more gracefully. On Nov 26, 2012, at 9:55 AM, Dominic Hamon [email protected] wrote: Fixed as in you changed the scheduler to not send to www.youtube.com? That's not really fixed as youtube is not the only culprit and users can On Mon, Nov 26, 2012 at 6:00 AM, drchoffnes [email protected]:
— |
My understanding is that Mobiperf does NOT follow HTTP redirects and On Mon, Nov 26, 2012 at 12:22 PM, drchoffnes [email protected]:
|
It does reduce the usefulness of the HTTP test though: If I go to a site It might be hard, but I think it's worth considering for a future update. On Mon, Nov 26, 2012 at 3:32 PM, Matt Welsh [email protected]:
|
I think it depends on what the HTTP test is meant to be used for. We On Mon, Nov 26, 2012 at 3:35 PM, Dominic Hamon [email protected]:
|
Maybe we should not report it as a failure if it gets a 302. It's not like I'm personally more in agreement with Matt, that the http probe should not On Mon, Nov 26, 2012 at 5:39 PM, Matt Welsh [email protected]:
|
It would be nice to cover both scenarios. Keep the vanilla HTTP test that does not follow redirects, but modify it so it does not treat a 302 as a failure (it is also worth considering how to handle 204, 301 and 304 responses, as there are valid 'success' cases that may return those codes). A new HTTP test that follows redirects with a max of say 5 redirects to avoid loops would provide additional valuable information. |
While this is being sorted out, it probably makes sense to remove the HTTP test for www.google.com, as it will fail for most non-US users due to geo detection and a 302 to the localized version of Google. |
Most mobile user agents will get a 302 to m.youtube.com if you try to fetch www.youtube.com, so the current test fails really often as it is not expecting a 302 response.
The text was updated successfully, but these errors were encountered: