feat: make it possible to disable tabs via frontmatter #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkoSagadin
force-pushed
the
feature/no_tabs
branch
from
2915cec to
bcea602
Compare
Mochitto
reviewed
Nov 12, 2024
| @@ -110,3 +110,34 @@ | |||
| @media (min-aspect-ratio: 1/1) | |||
| max-width: 70vw | |||
| padding: 35px 25px | |||
|
|
|||
| .body | |||
There was a problem hiding this comment.
I think .card-body could be better; there's a tag in HTML and it could look like we are styling that, instead of styling the card itself :)
Avoid .card as that's a reserved class used by anki
With this change is now possible to disable presence of tabs, by adding the below frontmatter snippet to the top of the markdown file: --- no_tabs: True --- If present then: - 'L', 'R', '-', '+' tab flags are ignored, only 'F' and 'B' matter. - Tab labels don't matter To avoid possible styling interference two new classes were created: body and body__content. They are a direct copy of the tab__body and tab__body_content classes, only that their display property is set to 'flex' instead of none. The python code now generates the html out of markdown as it would normally and wraps content in the above two mentioned containers. That way no tab-related styling is present. Finally, all the changes in the main.ts make the presence of the .tab_group selector optional. If not found then no extra logic is enabled and content is present on single page.
MarkoSagadin
force-pushed
the
feature/no_tabs
branch
from
bcea602 to
d98202b
Compare
|
I have renamed the CSS class and added entries to README and CHANGELOG. Tell me what you think :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change is now possible to disable presence of tabs, by adding the below frontmatter snippet to the top of the markdown file:
no_tabs: True
If present then:
To avoid possible styling interference two new classes were created: body and body__content. They are a direct copy of the tab__body and tab__body_content classes, only that their display property is set to 'flex' instead of none.
The python code now generates the html out of markdown as it would normally and wraps content in the above two mentioned containers. That way no tab-related styling is present.
Finally, all the changes in the main.ts make the presence of the .tab_group selector optional. If not found then no extra logic is enabled and content is present on single page.
Take this as a work in progress. The functionality is there, but there are definitely things that could be better placed or done differently. Also, some things should probably be better documented.
Please point out what needs to be improved or changed.