Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Map Trace Checker #42

Open
bestchai opened this issue May 26, 2020 · 0 comments
Open

Clean up Map Trace Checker #42

bestchai opened this issue May 26, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@bestchai
Copy link
Member

bestchai commented May 26, 2020

While a lot of comments were added to the find first/ find last occurrence methods in map trace checker a while back, the code remains very dense and hard to read. That is to say it is fertile breeding ground for bugs and frustration from future developers. (In fact, we see many bugs exist in the map trace checker as is).

Some ideas:

  • Refactor first and second into p and q as in main check methods.
  • Refactor main check methods to take in only start position if this improves readability.
  • Find first and Find last methods contain same case structure as checkers. It may be worth abstracting these to take advantage of that inheritance.

[Issue created by carolemieux: 2014-08-27]

@bestchai bestchai added the enhancement New feature or request label May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant