Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #571: Compatibility with >= Numpy 2.0.0 (update of ptp method) #572

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

Chip2916
Copy link
Contributor

@Chip2916 Chip2916 commented Oct 1, 2024

#571

In this PR:

  • Replaced use of x.ptp() with np.ptp(x) as per depreciation of x.ptp() as part of migration to Numpy 2.0.0.
  • Although not raised in original issue, when running tests noticed that they have also depreciated the use of np.Inf to ensure there is only one way to call the attribute. Therefore have replaced np.Inf with np.inf where it appears in package.

Notes:

  • Existing unit tests cover changes

@Chip2916
Copy link
Contributor Author

Chip2916 commented Oct 1, 2024

This PR is related to issue #571

@hbaniecki
Copy link
Member

thanks!

@hbaniecki hbaniecki merged commit 2f31550 into ModelOriented:master Oct 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants