Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep track of dimnames #96

Closed
mayer79 opened this issue Jun 6, 2023 · 1 comment · Fixed by #102
Closed

Keep track of dimnames #96

mayer79 opened this issue Jun 6, 2023 · 1 comment · Fixed by #102
Assignees
@mayer79
Labels
enhancement New feature or request

Comments

@mayer79
Copy link
Collaborator

mayer79 commented Jun 6, 2023

kernelshap involves working with different matrices of different shapes.

We should consistently use feature names for the "p" dimension and prediction names (if available) for the "K" dimension. This would make the code easier to read.
@mayer79 mayer79 added the enhancement New feature or request label Jul 17, 2023
@mayer79 mayer79 self-assigned this Jul 17, 2023
@mayer79 mayer79 mentioned this issue Sep 12, 2023
Merged
@mayer79
Copy link
Collaborator Author

mayer79 commented Sep 12, 2023

Implemented in #102

@mayer79 mayer79 closed this as completed Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayer79 mayer79

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code optim ModelOriented/kernelshap
1 participant
@mayer79