Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect accepting states for arbitrary topological ordering #13

Closed
ChieloNewctle opened this issue Oct 18, 2023 · 1 comment
Closed
Assignees

Comments

@ChieloNewctle
Copy link
Contributor

ChieloNewctle commented Oct 18, 2023

A topological ordering of states is not necessarily an ordering from link parents to their children.

The current implementation is correct, because the topological sorting is in a manner of BFS, where NO states with longer maximum suffix lengths are visited earlier than states with shorter ones.

So the interface name of get_topo_sorted_node_ids will soon be changed into a more precise one. And there will be another test to verify this property.

@ChieloNewctle ChieloNewctle changed the title Incorrect accepting states! Incorrect accepting states for arbitrary topological ordering. Oct 18, 2023
@ChieloNewctle ChieloNewctle changed the title Incorrect accepting states for arbitrary topological ordering. Incorrect accepting states for arbitrary topological ordering Oct 18, 2023
@ChieloNewctle ChieloNewctle self-assigned this Oct 18, 2023
@ChieloNewctle ChieloNewctle pinned this issue Oct 18, 2023
@ChieloNewctle
Copy link
Contributor Author

#14

@ChieloNewctle ChieloNewctle unpinned this issue Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant