From d57572125b2fe7bc868a10230f553c9a80de39c5 Mon Sep 17 00:00:00 2001
From: Gerhard Hippmann <gerhard.hippmann@dlr.de>
Date: Thu, 8 Sep 2022 18:18:54 +0200
Subject: [PATCH] Improve efficiency of FileMesh support point calculation

dot() in Float64 without broadcast yields minimum computation and memory allocation effort.
---
 src/Shapes/boundingBoxes.jl | 24 ++++++++++--------------
 1 file changed, 10 insertions(+), 14 deletions(-)

diff --git a/src/Shapes/boundingBoxes.jl b/src/Shapes/boundingBoxes.jl
index 8882255..f10660b 100644
--- a/src/Shapes/boundingBoxes.jl
+++ b/src/Shapes/boundingBoxes.jl
@@ -247,21 +247,17 @@ end
 
 # [Gino v.d. Bergen, p. 131]
 @inline function supportPoint_abs_FileMesh(shape::FileMesh, e_abs::SVector{3,T}) where {T}
-    #e_absVec = Vector{SVector{3,Float64}}(undef, 1)
-    #e_absVec[1] = e_abs
-    #(max_value, position) = findmax(broadcast(dot, shape.objPoints, e_absVec))
-    #return SVector{3,T}(shape.objPoints[position])
-    iMax::Int = 1
-    dotMax::T = typemin(T)
-    objPoints = shape.objPoints
-    for i in 2:length(shape.objPoints)
-        doti = dot(objPoints[i],e_abs)
-        if doti > dotMax
-            iMax = i
-            dotMax = doti
+    dirvec = SVector{3,Float64}(e_abs)
+    idxmax = 1
+    dotmax = typemin(Float64)
+    for idx in eachindex(shape.objPoints)
+        dotval = dot(shape.objPoints[idx], dirvec)
+        if dotval > dotmax
+            idxmax = idx
+            dotmax = dotval
         end
-    end        
-    return objPoints[iMax]
+    end
+    return SVector{3,T}(shape.objPoints[idxmax])
 end