Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paramters of "revertRevoluteKind" ? #139

Closed
johhell opened this issue Jan 30, 2024 · 2 comments
Closed

paramters of "revertRevoluteKind" ? #139

johhell opened this issue Jan 30, 2024 · 2 comments

Comments

@johhell
Copy link
Contributor

johhell commented Jan 30, 2024

tried to understand Modia3D and found some functions are not clear for me.

revolute.jl

function revertRevoluteKind defines 2 parameters, but oldChild::Object3D{F} is never used.

function revertRevoluteKind!(oldChild::Object3D{F}, newChild::Object3D{F}) where F <: Modia3D.VarFloatType

joints.jl

This function is used in joints.jl in function jointSpecificTreatment

revertRevoluteKind!(oldChild, newChild)

with 2 parameters (oldChild, newChild)

handler.jl

The function jointSpecificTreatment is used in handler.jl in jointSpecificTreatment!(newChild, oldChild)

jointSpecificTreatment!(newChild, oldChild)

newChild here is the first parameter.
all other functions uses the order (oldChild, newChild)

@AndreaNeumayr
Copy link
Member

Thanks for your hints. I'll change that.

@AndreaNeumayr
Copy link
Member

See #140

GerhardHippmann added a commit that referenced this issue Jan 31, 2024
changed functions according to issue #139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants