-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hair Strand Color adjustment/fix. #4839
Comments
couple of things:
|
If that was the case, then someone else with better visual acuity would have brought this up sooner.
well not quite since someone has to verify that the images look fine, have no artifacts and are exported with the correct interpolation settings. And since these are base images, they have to be added to the base psd. You're free to submod these if you'd like. |
The majority of MAS users most likely don't even have a GitHub account to comment on problems they notice, or have Discord/access to the MAS Discord server, so they'd just have to put up with it for all we know. If more than 100k people have downloaded MAS, then certainly a good portion of them aren't on the MAS Discord server.
I don't see this as much of a problem that can't be resolved with a simple addition to the PSD section of the art guidelines here: #3174. Giving more specific requirements for how the images should be exported could only reduce the amount of work you yourself have to do. |
I already do mention the export steps, but there's no reason to just blindly accept that people will export the sprites correctly. Everything has to be reviewed, especially if its something that would be added to the base psds. |
Okay, so what does this reviewing process involve? Also you already mentioned the exact specifications for exporting base art properly? |
I mentioned checking artifacts, there's also ensuring the sprites fit in the correct render order, and general quality review. Base sprites get reviewed with more scrutiny, I look for transparency holes, linework issues, color issues, and more.
go to the psd issue and scroll down past the revision history.
While yes it would save me work by just letting others export the sprites and putting them in, I want to ensure the sprites being added to base/spritepacks (and effectively being promoted by us) are of good quality. Finally, to reiterate, the primary reason why I'm not looking to add these changes is because dev team and I have agreed that the proposed changes are unnecessary and not needed. We don't see an issue with the current hair strands. |
if you want to submod this, make a new issue. |
In game it's fairly noticeable that Monika's left hair strand (her left) changes color around the mid section:
Here's a comparison between the adjustment I've been trying to make and the current version/how it looks in game:
Current:
Adjustment:
The text was updated successfully, but these errors were encountered: