Skip to content
This repository has been archived by the owner on Mar 7, 2020. It is now read-only.

[WIP] PoC - add Docker for Monofony #239

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

gabiudrescu
Copy link

@gabiudrescu gabiudrescu commented Jan 2, 2020

Fixes #193

What I did:

  • I took the docker configuration from SyliusStandard and adapted it to Monofony
  • improved it to match some of my requirements, such as:
    -- not running containers as root
    -- solved some caching issues with docker and docker-compose by using a scratch container to have a copy of all files from context
    -- added redis to be able to use same session from multiple containers
    -- switched the hardcoded locale to an env parameter

Still to do:

  • add documentation done
  • add ability to run testing suite from containers decided not to tackle this now
  • add gitlab-ci.yml to allow ci on gitlab done
  • move docker registry to dockerhub done

@gabiudrescu
Copy link
Author

I did this PR because I wanted to start working on #238 and I realized that I don't have a working environment on my laptop. And since I created a Docker setup for me, I thought it would be nice to submit it here as well.

@gabiudrescu gabiudrescu force-pushed the feature/docker branch 2 times, most recently from 0e1e860 to f159afa Compare January 2, 2020 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker environment setup
1 participant