Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Animate Spawned Blocks #646

Open
2 tasks done
Aspirata opened this issue Jan 7, 2025 · 5 comments
Open
2 tasks done

Cannot Animate Spawned Blocks #646

Aspirata opened this issue Jan 7, 2025 · 5 comments

Comments

@Aspirata
Copy link
Contributor

Aspirata commented Jan 7, 2025

Did the issue happen after restarting Blender?

  • Yes, the issue indeed continued after restarting Blender

Check known issues

  • I have checked known issues, and my problem is different

What happened?

Animate Textures in prep materials doesn't work on spawned blocks

What steps are needed to produce the bug?

  1. Spawn any animated block (sculk, sea lantern, nether portal etc)
  2. Prep it with Animate Textures enabled
  3. See the bug

What version of MCprep are you using?

3.6.1.2

What version of Blender are you using?

Blender 4.4, but you can reproduce that bug on any version of blender starting with 4.0

@Aspirata
Copy link
Contributor Author

Aspirata commented Jan 7, 2025

This can be fixed by removing the material post-fix (west, north, all, etc.)

@Aspirata
Copy link
Contributor Author

Aspirata commented Jan 7, 2025

Btw why does Mcprep create a new material for each side of the block, even if they have the same UV and texture ?

@zNightlord
Copy link
Contributor

zNightlord commented Jan 8, 2025

Is the issue happened in the dev branch? #644
That commit should already fix blocks with actual face change like crafting table only do west south east materials. Block only "all" use one.

@Aspirata
Copy link
Contributor Author

Aspirata commented Jan 8, 2025

This happens even in the dev branch. Btw it still creates a separate material for each face
image

@zNightlord
Copy link
Contributor

zNightlord commented Jan 8, 2025

Btw why does Mcprep create a new material for each side of the block, even if they have the same UV and texture ?

Minecraft Java json model system is like OOP in programming, polymorphism, its rather contains the same place it goes:
this file contains that block "name" model textures has "all" texture but reference other file "parent" that has the geometry with each face map reference "all" as "#all" to use from the child block "name" file

the parent in sea_lantern.json maybe "cube_all' but it goes back to "cube" to create the geometry for each face direction for material assign based on the stored index list

Maybe have to properly remap those textures

uxv9u2.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants