Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My boss, MRE version 2.1 ready? #168

Open
hzeasy opened this issue Oct 13, 2023 · 12 comments
Open

My boss, MRE version 2.1 ready? #168

hzeasy opened this issue Oct 13, 2023 · 12 comments

Comments

@hzeasy
Copy link

hzeasy commented Oct 13, 2023

lllyasviel has recently been updated to 2.1.53, and his latest technology upgrade is really good, but I am still willing to use MRE, and hope I can get the latest MRE! Strong supporter of MRE.
@MoonRide303

@MoonRide303
Copy link
Owner

@hzeasy I've spent some time on merging changes from 2.1 locally, but... it's get more and more frustrating, having to re-write half of my code every time original Fooocus gets major update. Spending a lot of time just to make things I already coded once work again, without any real value added - that's not really productive, or fun.

Taking that into account, and that most features and optimizations I was missing in vanilla are already available in v2.1 - I decided that MRE v2.0.78.5 will be the last release.

Thank you for your support and kind words, and... enjoy creating interesting art, whatever tool you'll use.

@lanyusan
Copy link

@MoonRide303
Have you decided to continue the development of this fork? I noticed the repo had been unlocked and unarchived.

It seems lllyasviel's releases have been really aggressive so he doesn't have much time to improve stability and memory issues.

Yours will be perfect compliment to the original fooocus release for heavy load use.

@MoonRide303
Copy link
Owner

MoonRide303 commented Oct 16, 2023

@lanyusan I noticed archiving the repo had 2 side-effects I wasn't previously aware of:

  • it shuts down ability to comment in issues and discussions,
  • it blocks ability to contribute to the original Fooocus (I cannot create another fork just for contributions to vanilla).

So I unarchived it mainly for those reasons.

For now I don't plan any new MRE updates - resolving large amount of conflicts on every major vanilla update was just too much for me. I will try to use original Fooocus (and maybe contribute to it), and see how it goes. I like UI of MRE more, and also QoL changes it has included - but most of those changes can be also added into vanilla (any many already are), so let's just hope it will be possible this way. Discussion about adding MRE features into original code base is happening here.

@lanyusan
Copy link

@lanyusan I noticed archiving the repo had 2 side-effects I wasn't previously aware of:

  • it shuts down ability to comment in issues and discussions,
  • it blocks ability to contribute to the original Fooocus (I cannot create another fork just for contributions to vanilla).

So I unarchived it mainly for those reasons.

For now I don't plan any new MRE updates - resolving large amount of conflicts on every major vanilla update was just too much for me. I will try to use original Fooocus (and maybe contribute to it), and see how it goes. I like UI of MRE more, and also QoL changes it has included - but most of those changes can be also added into vanilla (any many already are), so let's just hope it will be possible this way. Discussion about adding MRE features into original code base is happening here.

Oh I see.
I totally understand your decision and wish you good luck.
Thanks.

@Aamir3d
Copy link

Aamir3d commented Oct 16, 2023

@MoonRide303 I also like the MRE interface (slightly biased here). Hopefully you can work with Ilyasviel to incorporate some of these features into the main Fooocus intefrace.

@bruno-c
Copy link

bruno-c commented Oct 23, 2023

Really loved working with this branch as well! Thank you!

If you and lllyasviel can agree on the direction the software will take and the features we love from MRE make it in, that'd be the best outcome for the users too. Open source and the whole concept of forks, etc is amazing but it can be very demanding to try to keep up, especially in this space where the tech is moving at warp speed.

I look at something like SD.NEXT and I would absolutely go crazy having to constantly keep track of and backport and merge features from 1111. It would also make refactoring incredibly difficult without paying for it forever with complex merges.

Thanks and good luck! I hope that we continue to see you contributing to the main repo!

@MoonRide303
Copy link
Owner

@bruno-c Thank you for kind words :). For now I'd like to chill out a bit more, slowly review all the MRE features, and bring those which are compatible with vanilla philosophy back to the core. This way more people will be able to benefit from it, and in case I ever decided to re-activate MRE it would be also easier to maintain, too (smaller delta, less conflicts). But in general maintaining single code base sounds more reasonable to me, so I guess I will stick to that path (at least for now).

I can also imagine providing MRE as alternative UI layout for more advanced users, available directly in vanilla - that could be good long-term solution, but I would need to figure out clean implementation for it, first (and make sure it doesn't break any of the vanilla assumptions).

@barepixels
Copy link

barepixels commented Oct 24, 2023

With your hard work, you have given us a wonderful flavor of Fooocus. I use Fooocus-MRE every day as my main Stable Diffusion UI. I was very sad when I thought you had let Fooocus-MRE die. Now I am relieved.

Here are few reasons Fooocus-MRE is my main tool

Added support for JPEGs (with metadata saving & loading)
Style Iterator
Load Last Prompt button
limited support for non-SDXL models
information about total execution time
img2img
SD1.5

@Aamir3d
Copy link

Aamir3d commented Oct 24, 2023

@bruno-c Thank you for kind words :). For now I'd like to chill out a bit more, slowly review all the MRE features, and bring those which are compatible with vanilla philosophy back to the core. This way more people will be able to benefit from it, and in case I ever decided to re-activate MRE it would be also easier to maintain, too (smaller delta, less conflicts). But in general maintaining single code base sounds more reasonable to me, so I guess I will stick to that path (at least for now).

I can also imagine providing MRE as alternative UI layout for more advanced users, available directly in vanilla - that could be good long-term solution, but I would need to figure out clean implementation for it, first (and make sure it doesn't break any of the vanilla assumptions).

As you can see from my response and @barepixels that MRE was pretty useful in the way the UI catered to ease of use (more practical). While the vanilla Fooocus is really good, there are some things that are not too intuitive (looking at the resolutions again), as well as waiting on JPG support.
If some things are integrated in vanilla, that's for the best.
As always, thank you for your hard work and effort.

Repository owner deleted a comment from fenneishi Oct 25, 2023
@MoonRide303
Copy link
Owner

@fenneishi Please don't post super-long promotional messages in unrelated issues / discussions. It's okay if you mention that your fork has feature X in issue / discussion related to feature X, but if you want to promote your fork (which btw. seems to be based on vanilla, not MRE), then best place for it would be probably this discussion.

@fenneishi
Copy link

@fenneishi Please don't post super-long promotional messages in unrelated issues / discussions. It's okay if you mention that your fork has feature X in issue / discussion related to feature X, but if you want to promote your fork (which btw. seems to be based on vanilla, not MRE), then best place for it would be probably this discussion.

I'm sorry, I sincerely apologize for my behavior.

@MoonRide303
Copy link
Owner

@fenneishi No worries - it's good to see another Fooocus fan, but let's just try to keep things a bit more organized / clean :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants