Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] infinite loop in list.sets() #91

Closed
ConduitDan opened this issue Feb 17, 2022 · 3 comments · Fixed by #108
Closed

[Bug] infinite loop in list.sets() #91

ConduitDan opened this issue Feb 17, 2022 · 3 comments · Fixed by #108
Assignees
@ConduitDan
Labels
bug Something isn't working

Comments

@ConduitDan
Copy link
Collaborator

var A = [1,2,3]
var B = A.sets(4)
causes morpho to hang followed by being killed :-(
@ConduitDan ConduitDan added the bug Something isn't working label Feb 17, 2022
@ConduitDan ConduitDan mentioned this issue Feb 17, 2022
Merged
@softmattertheory
Copy link
Contributor

@ConduitDan Great you are assigned to this!

@softmattertheory
Copy link
Contributor

Any progress on this?

@ConduitDan
Copy link
Collaborator Author

added some argument checking to the set operation

    if (n>slf->val.capacity) n = slf->val.capacity;

Working on #38 and #77 in one branch, I plan on posting a pull request this afternoon

@ConduitDan ConduitDan mentioned this issue Mar 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ConduitDan ConduitDan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug fix Morpho-lang/morpho
2 participants
@softmattertheory @ConduitDan